VSCode warnings #423
Merged
VSCode warnings #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed a bunch of iterations from `for i in 1:length(vec)` to `for i in eachindex(vec)`. I substituted a loop with a list comprehension because it seemed faster and clearer to read. I correct some spelling typos in comments in the code. I replaced comparisons of the type `a == nothing` with `isnothing(a)`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
=======================================
Coverage 97.31% 97.31%
=======================================
Files 117 117
Lines 6956 6956
=======================================
Hits 6769 6769
Misses 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Krastanov
approved these changes
May 14, 2025
Member
Krastanov
left a comment
Krastanov
left a comment
There was a problem hiding this comment.
Thanks! LGTM
Small changes like this are the best -- easy to review and definite code quality improvements. Multiple small PRs are always preferred over one big PR>
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did.
for i in 1:length(vec)tofor i in eachindex(vec);for i in 1:length(vec)tofor item in vec;a == nothingwithisnothing(a).I run the tests locally and there were no problems.
Why I did it.
Possible method call error, which I don't really know how to fix;They are very small changes and definitely not very important. I hope they are welcome anyway. If not (for example because reviewing them would take away time from the maintainer which would be better spent otherwise) do not hesitate to let me know, so that I won't do similar pull requests in the future.